Skip to content

Better visual centering of text #8320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davepagurek merged 6 commits into from
Dec 5, 2025
Merged

Better visual centering of text #8320

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
adc1064
Better visual centering of text
davepagurek Dec 3, 2025
522a2ca
Update centering code
davepagurek Dec 4, 2025
6cb2508
Revert screenshot updates
davepagurek Dec 4, 2025
1cb1d5f
Merge branch 'dev-2.0' into fix/font-align
davepagurek Dec 4, 2025
dacb940
Merge branch 'dev-2.0' into fix/font-align
davepagurek Dec 4, 2025
52c4266
Add visual tests for vertical alignment
davepagurek Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/type/textCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2518,6 +2518,21 @@ function textCore(p5, fn) {
return this._pInst;
};

Renderer.prototype._middleAlignOffset = function() {
const { textFont, textSize } = this.states;
const font = textFont?.font;
const ctx = this.textDrawingContext();
const metrics = ctx.measureText('X');
let sCapHeight = (font?.data || {})['OS/2']?.sCapHeight;
if (sCapHeight) {
const unitsPerEm = font.data.head.unitsPerEm;
sCapHeight *= textSize / unitsPerEm;
} else {
sCapHeight = metrics.fontBoundingBoxAscent;
}
return metrics.alphabeticBaseline + sCapHeight / 2;
};

if (p5.Renderer2D) {
p5.Renderer2D.prototype.textCanvas = function () {
return this.canvas;
Expand Down Expand Up @@ -2607,7 +2622,7 @@ function textCore(p5, fn) {
case fn.BASELINE:
break;
case textCoreConstants._CTX_MIDDLE:
yOff = ydiff / 2;
yOff = ydiff / 2 + this._middleAlignOffset();
break;
case fn.BOTTOM:
yOff = ydiff;
Expand Down Expand Up @@ -2712,7 +2727,7 @@ function textCore(p5, fn) {
case fn.BASELINE:
break;
case textCoreConstants._CTX_MIDDLE:
yOff = (-totalHeight + textSize + (height || 0)) / 2 + this._verticalAlignFont();
yOff = (-totalHeight + textSize + (height || 0)) / 2 + this._verticalAlignFont() + this._middleAlignOffset();
break;
case fn.BOTTOM:
yOff = -(totalHeight - textSize) + (height || 0);
Expand Down
Loading