WOFF font support #7449
WOFF font support #7449
Conversation
dhowe
commented
Dec 27, 2024
•
dhowe
commented
- Add WOFF support via upgraded Typr.js
- Fixes null argument bug in fontWidth/textWidth
- Fixes direct-font-set triggering on non-string fonts
There was a problem hiding this comment.
Looks like the test for this still exists, were these meant to be deleted? If not, we can restore by running this then committing the results:
git checkout dev-2.0 -- "test/unit/visual/screenshots/Typography/textWeight/can control variable fonts from files"There was a problem hiding this comment.
tests still failing after I restored those files, but now with a pixel mismatch -- I regenerated the screenshots but still needs a visual check
There was a problem hiding this comment.
It looks like the font has changed now, so I think pixel mismatch failures were actually correct in this instance, and something about font loading has changed:
|
@limzykenneth looks like we just merged some FES changes into dev-2.0, I think they might be causing some test failures |
|
Yeah still fixing it, the test for FES may need to be rewritten a bit and some outdated documentation around parameters may also need to be updated. I'll push fixes some time next week. |
