-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Converts CM5 into CM6 #3500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop-codemirror-v6
Are you sure you want to change the base?
Converts CM5 into CM6 #3500
Conversation
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-3cdba4e141 |
af10dc9
to
0cf467a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your work on this—I think this overall feels really solid!
I did some manual testing, and everything seems to function as expected besides the elements that you've already noted as TODOs! I just had a small question in codemirror.js
, but aside from that that this feels like it's in a great place to me!
Fixes #issue-number
Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123