[#3444] Add keyboard shortcut update functionality#3445
Open
karanBRAVO wants to merge 2 commits intoprocessing:developfrom
Open
[#3444] Add keyboard shortcut update functionality#3445karanBRAVO wants to merge 2 commits intoprocessing:developfrom
karanBRAVO wants to merge 2 commits intoprocessing:developfrom
Conversation
Contributor
Author
|
Hello @raclim, One more thing to say, this PR is not yet completed, I have to add the same thing for all shortcuts. |
Collaborator
|
Thanks for the update on this! I shared my thoughts about the development for this issue in its thread. Ideally, a pull request should be complete before submission. Since it's not complete yet, could you mark this as a draft instead? |
This PR add more shortcuts to the map which user can change.
a46fa6e to
cbc82da
Compare
Contributor
Author
|
Hello @raclim, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds the Edit button in keyboard shortcut modal, so that users can change the keyboard shortcuts.
Fixes #3444
Changes:
editbuttoncontextto sharekeyMapsandupdateKeyMapsfunctionI have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123