Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed for Cannot create SharedArrayBuffer #3218

Closed
wants to merge 2 commits into from

Conversation

Noorain464
Copy link

@Noorain464 Noorain464 commented Aug 11, 2024

Fixes #issue-number:Cannot create a SharedArrayBuffer #2094

Changes:
Screenshot from 2024-08-11 18-09-06

Screenshot from 2024-08-11 18-25-52

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@Noorain464 Noorain464 changed the title Shared Buffer Array Bug fixed for Cannot create SharedArrayBuffer Aug 12, 2024
@raclim
Copy link
Collaborator

raclim commented Aug 12, 2024

Thanks for your work on this!

It seems that the solution here is similar to the one provided in an earlier PR, which I closed since it didn't seem to entirely work, and I'm not able to do it here either.

Based on the example code provided in the issue, it seems like this is what is supposed to happen when it's working, which also doesn't seem to appear in the screenshots you've provided.
Screenshot 2024-08-12 at 12 15 08 PM

Since we've closed a PR with a similar solution to this, I'm going to close this one as well. I'm sorry that we couldn't get this in, but please feel free to reopen this with any updates!

@raclim raclim closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants