Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : [#2488] Edit svg file to resolve the issue. #2494

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Fix : [#2488] Edit svg file to resolve the issue. #2494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
328d06b
Fix : [#2488] Edited svg & related files to resolve the issue.
Ri-Sharma Oct 7, 2023
c46a1b1
Merge branch 'develop' into develop
raclim Nov 3, 2023
eb34421
Merge branch 'develop' into develop
lindapaiste Nov 12, 2023
1b81f72
Merge branch 'develop' into develop
lindapaiste Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions client/images/p5js-logo-small.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 11 additions & 6 deletions client/styles/components/_nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,21 +162,26 @@
position: absolute;
}
}
.svg__logo g > path {

.svg__logo {

@include themify() {
fill: getThemifyVariable('logo-color');
// Set background color of the logo
background-color: getThemifyVariable('logo-color');
}
}
.svg__logo g g:first-of-type path {
fill: none;

}

.svg__logo g g:first-of-type use {
.svg__logo g path{

@include themify() {
// Set internal color of the logo;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments will be helpful to anyone looking at this. Because now that we inverted the SVG file the naming is kind of backwards isn't it! 'logo-color' is the background and 'logo-background-color' is the text 😆 .

fill: getThemifyVariable('logo-background-color');
}

}


.nav__keyboard-shortcut {
font-size: #{12 / $base-font-size}rem;
font-family: Inconsololata, monospace;
Expand Down
Loading