Skip to content

Moved DashboardView to Functional Component #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

up1512001
Copy link

@up1512001 up1512001 commented Sep 15, 2023

Fixes #2358 (DashboardView.jsx)

Changes: from class component to functional component

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@up1512001
Copy link
Author

up1512001 commented Sep 15, 2023

I have run npm run test and npm run lint.
(Image of test)(https://drive.google.com/file/d/1tnMinZISvnJpoymG8Lzm27R3R_6hmtsj/view?usp=sharing)

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lindapaiste
Copy link
Collaborator

Thanks for you contribution. We had a lot of people working on the same components so I am closing this PR as we already merged another PR for DashboardView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert legacy React class components to function components
3 participants