Skip to content

updated Searchbar class component to functional component #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ankit9928
Copy link

@ankit9928 ankit9928 commented Sep 14, 2023

Fixes #2358

Changes:

I have verified that this pull request:

  • [ yes] has no linting errors (npm run lint)
  • [yes ] has no test errors (npm run test)
  • [yes] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [ yes] is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 14, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Sep 14, 2023

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-80f3ee8266

@ankit9928
Copy link
Author

Thanku

@lindapaiste
Copy link
Collaborator

I'm going to close this PR because we have a bunch for this component and the throttle is not handled properly here. The throttledSearchChange function will get re-created on each re-render so it won't be effective at throttling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert legacy React class components to function components
2 participants