Skip to content

covert SketchListRowBase Class to Functional compontent #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mubacodestudio
Copy link

@mubacodestudio mubacodestudio commented Sep 12, 2023

Fixes Ref #2358

Changes: change SketchListRowBase to Functional component

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 12, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lindapaiste
Copy link
Collaborator

I'm going to close this PR because it has conflicts with other recent changes to the develop branch but also has major problems of its own.

When running this branch I am unable to view the /sketches page and I get an error:

Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.

You've removed the part where the SketchListRowBase gets connected to Redux which means that a lot of its props are now missing, as they are neither passed down from the parent nor provided by Redux. Those missing function props will cause errors when those functions are called.

In the future please run your code and make sure that it works before submitting PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants