remove unnecessary stringify and parsing

probot · Nov 22, 2023 · 69748c0 · 69748c0
1 parent 08bb764
commit 69748c0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/event-bus.js b/lib/event-bus.js
@@ -40,8 +40,7 @@ function EventBus ({ logger = console } = {}) {
   this.sub.on('message', (_, message) => {
     const channel = message.slice(0, message.indexOf(':'))
     if (this.events.listenerCount(channel)) {
-      const payload = JSON.parse(message.slice(channel.length + 1))
-      return this.emitLocalEvent({ channel, payload })
+      return this.emitLocalEvent({ channel, payload: message.slice(channel.length + 1) })
     }
   })
 }

diff --git a/lib/server.js b/lib/server.js
@@ -92,7 +92,7 @@ const files = [
   })
 
   fastify.decorateReply('sse', function (payload, event) {
-    this.raw.write(`id: ${this.message_count++}\n${event ? `event: ${event}\n` : ''}data: ${JSON.stringify(payload)}\n\n`)
+    this.raw.write(`id: ${this.message_count++}\n${event ? `event: ${event}\n` : ''}data: ${typeof payload === 'object' ? JSON.stringify(payload) : payload}\n\n`)
   })
 
   // Setup interval to ping every 30 seconds to keep the connection alive