cmsisdap: don't do i/o for the iface string when listing devices. #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
added
the
changelog:skip
nusb added an API to list basic interface info from DeviceInfo which does no actual USB I/O to the device (info is cached by the OS when plugging in the device). This includes the interface string, which we use to detect CMSIS-DAP interfaces.
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nusb added an API to list basic interface info from DeviceInfo which does no
actual USB I/O to the device (info is cached by the OS when plugging in the device).
This includes the interface string, which we use to detect CMSIS-DAP interfaces.
This takes
probe-rs listin the Embassy CI machine (52 USB devices, 32 probes) from 900ms to 60ms.see kevinmehall/nusb#28