chore: Use pixi for backend tests #1331
Conversation
glemaitre
requested review from
thomass-dev,
rouk1 and
auguste-probabl
as code owners
Coverage Report for frontend
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
| # 1. Support for Python versions be dropped 3 years after their initial release. | ||
| # 2. Support for core package dependencies be dropped 2 years after their initial |
There was a problem hiding this comment.
| # 1. Support for Python versions be dropped 3 years after their initial release. | |
| # 2. Support for core package dependencies be dropped 2 years after their initial | |
| # 1. Support for Python versions will be dropped 3 years after their initial release. | |
| # 2. Support for core package dependencies will be dropped 2 years after their initial |
|
Yep it is just a POC for the moment. I wanted to have this such that we have a starting point to speak with @auguste-probabl and @thomass-dev |
There was a problem hiding this comment.
I find the pixi DX very nice. I wont approve this PR as I know other people may have strong divergent opinion on this.
To me, to get this merge, you should delete the top level makefile as it is replaced by pixi scripts. And address (or not^^) my comment on non DOS-compatible command usage.
Too bad that pixi can't manage installing a javascript runtime...
| [tool.pixi.tasks] | ||
| clean-skore-ui = { cmd = "rm -rf skore-ui/dist/ && rm -rf skore/src/skore/ui/static/", cwd = "../" } | ||
| build-skore-ui = { cmd = "npm install && npm run build", cwd = "../skore-ui" } | ||
| move-skore-ui = { cmd = "mv skore-ui/dist/ skore/src/skore/ui/static/", cwd = "../" } | ||
| setup-skore-ui = { cmd = "echo 'Skore UI setup complete'", cwd = "../", depends-on = ["clean-skore-ui", "build-skore-ui", "move-skore-ui"] } | ||
|
|
||
| [tool.pixi.feature.doc.tasks] | ||
| build-docs = { cmd = "make html", cwd = "../sphinx" } | ||
| build-docs-quick = { cmd = "make html-noplot", cwd = "../sphinx" } | ||
| clean-docs = { cmd = "rm -rf build/ && rm -rf auto_examples/ && rm -rf reference/api/", cwd = "../sphinx" } | ||
|
|
||
| [tool.pixi.feature.lint.tasks] | ||
| lint = { cmd = "pre-commit install && pre-commit run -v --all-files --show-diff-on-failure", cwd = "../" } | ||
|
|
||
| [tool.pixi.feature.test.tasks] | ||
| tests = { cmd = "mkdir -p coverage && python -m pytest -n auto src/ tests/ --junitxml=coverage/coverage.xml --cov-config=pyproject.toml --cov | tee coverage/coverage.txt" } |
There was a problem hiding this comment.
Not sure if my comment is pertinent ^^
But... Using pixi as a task runner, allows to write this stuffs in python. Which make the repo windows friendly. Hence maybe we can avoid using rm, mv, mkdir, ...).
There was a problem hiding this comment.
Yes it is indeed one of the thing that I would like to have and indeed I did not make it DOS-compliant in my first pass.
I'm thinking that spin (https://github.com/scientific-python/spin) could help if we don't want to bother for some of the part :)
|
I've just had a really quick look and i find it really more complex. I need to deep-dive into your PR and maybe we should have a pair-session :). |
|
Now that I've seen what EDIT: Solved with uv in #1418 |
This works well outside NixOS 😉 . |
|
Giving a try to
pixifor the CI