#7 onSlide/onSlideEnd binding issue

princejwesley · Jul 30, 2015 · 5a1ea28 · 5a1ea28
1 parent 09843b8
commit 5a1ea28
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -26,8 +26,8 @@ var app = angular.module('yourApp',
   shape='{{shape}}'
   touch="true"
   animate='true'
-  on-slide='onSlide(value)'
-  on-slide-end='onSlideEnd(value)'
+  on-slide='onSlide'
+  on-slide-end='onSlideEnd'
   min="min"
   max="200"
   value="value">
@@ -146,8 +146,8 @@ scope: {
   animateDuration: '=?',
   selectable: '=?',
   disabled: '=?'
-  onSlide: '&',
-  onSlideEnd: '&',
+  onSlide: '=',
+  onSlideEnd: '=',
 },
 ```
 ### Watchers

diff --git a/dist/css/angular-circular-slider.min.css b/dist/css/angular-circular-slider.min.css
diff --git a/dist/js/angular-circular-slider.min.js b/dist/js/angular-circular-slider.min.js
diff --git a/examples/demo.html b/examples/demo.html
@@ -9,25 +9,26 @@
 
 	<body ng-controller="test">
 	<script> 
+
     var app = angular.module('test-cs', ['angular.circular-slider']);
     app.controller('test', function ($scope) {
     	$scope.min = 10;
     	$scope.max = 100;
     	$scope.shape='Circle';
     	$scope.value = 20;
 
-			$scope.onSlide = function(value) {
+			$scope.onSlide = function onSlide (value) {
 				console.log('on slide  ' + value);
 			}
 
-			$scope.onSlideEnd = function(value) {
+			$scope.onSlideEnd = function onSlideEnd(value) {
 				console.log('on slide end  ' + value);
 			}
     });
 	</script>
 
 	<h2> circular slider directive </h2>
-	<circular-slider class='my-slider' shape='{{shape}}' touch="true" animate='true' on-slide='onSlide(value)' on-slide-end='onSlideEnd(value)' min="min" max="200" value="value">
+	<circular-slider class='my-slider' shape='{{shape}}' touch="true" animate='true' on-slide='onSlide' on-slide-end='onSlideEnd' min="min" max="200" value="value">
 		{{value}}
 	</circular-slider>
 	</body>

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "angular-circular-slider",
-	"version": "1.0.0",
+	"version": "1.0.1",
 	"author": "prince john wesley <[email protected]>",
 	"description": "Angular circular slider",
 	"devDependencies": {

diff --git a/src/js/angular-circular-slider.js b/src/js/angular-circular-slider.js
@@ -719,8 +719,8 @@ Copyright (c) 2015 Prince John Wesley ([email protected])
         animateDuration: '=?',
         selectable: '=?',
         disabled: '=?',
-        onSlide: '&',
-        onSlideEnd: '&',
+        onSlide: '=',
+        onSlideEnd: '=',
       },
       link: link,
     };