Restore locales to previous behavior #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wied03
commented
Dec 23, 2025
| if (locales.isEmpty()) { | ||
| // request.getLocale() returns a default locale if none are set by httpRequestConsumer but | ||
| // we still want to set to the system's default, if none were explicitly set. | ||
| locales = List.of(Locale.getDefault()); |
Contributor
Author
There was a problem hiding this comment.
Can't do it the old way, because now with multiple header support working correctly, that breaks LocaleActionTest
bhalsey
reviewed
Dec 23, 2025
Comment on lines
849
to
854
| List<Locale> locales = request.getLocales(); | ||
| if (locales.isEmpty()) { | ||
| // request.getLocale() returns a default locale if none are set by httpRequestConsumer but | ||
| // we still want to set to the system's default, if none were explicitly set. | ||
| locales = List.of(Locale.getDefault()); | ||
| } |
Contributor
There was a problem hiding this comment.
we should move these lines down to line 890 where locales is used.
Then we won't need the if clause, if (!locales.isEmpty()) {
Contributor
Author
There was a problem hiding this comment.
Yeah good idea. Pushed.
bhalsey
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a framework problem per se, but a lot of tests in applications that use PMVC expect this header to be set on test requests using
RequestBuilder.