Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RC-28267): Create LogoImage Component #1544

Closed
wants to merge 4 commits into from

Conversation

annedaeunlee
Copy link
Collaborator

@annedaeunlee annedaeunlee commented Jan 6, 2025

What changes were made:

  • Create new component in packages/core called LogoImage
  • Prop design is similar to what PPS has, which is max-width, max-height, object-fit: contain, and margin: auto. Additionally, the component takes in an alt (string), src (string), and size (enumeration of 'small' or 'med')

Why:

  • Following this RC ticket to make partner logo sizes consistent across all apps (listings/checkout/post-booking)
  • Worked with designer to come up with two overarching sizes: small with maxHeight 16px and maxWidth 60px, med with maxHeight 28px and maxWidth 104px
  • Thought it would be a good idea to turn this into a component, since there have been so many different sizes used so far

How:

  • Created LogoImage folder inside packages/core. It has component file, test file, and storybook file (description included).
  • Added LogoImage as an export inside packages/core/index.js
  • Ran rush change

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.93%. Comparing base (2c29662) to head (fdbaf90).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
+ Coverage   93.86%   93.93%   +0.07%     
==========================================
  Files         154      155       +1     
  Lines       11452    11495      +43     
  Branches      705      706       +1     
==========================================
+ Hits        10749    10798      +49     
+ Misses        679      676       -3     
+ Partials       24       21       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant