Implement definition of foreign enums by reference to original definition in foreign module #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 20, 2015 16:59
added 2 commits
July 22, 2015 12:15
Generate only abstract types for enums from transitive dependencies. This causes enum generation to happen in three variants: - regular for locally defined enums - with indirection for enums defined in direct dependency - without member access (abstract type over integers) for enums defined in transitive dependency This seems like a lot of complexity, but I am coming to believe that it is necessary complexity. It mirrors the three forms of module generations for local, direct and transitive modules, where we generate the full definition, then the accessor, then only the types (and right now, erroneously I think, the enums).
rosadam
added a commit
that referenced
this pull request
Jul 28, 2015
Implement definition of foreign enums by reference to original definition in foreign module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes enums robust against reordering as discussed in #200.