Fixed switchout bug in multibattle where order of mons gets messed up

[shachar700]

Fixed switchout bug that messed the order of pokemon in the summary screen after the opponent uses switchout moves (whirlwind, roar, etc...).

PROBLEM:

PROBLEM: If the opponent uses forced switchout moves in a multi battle, the player side party might get the order messed up where the mons appear in the wrong slots of the party screen.
This causes a hardlock when all mons on the player side are knocked out and the player can't select their mon that's on the partner side of the party screen.

FIX: Entered the switchout effects inside the if (TryDoForceSwitchOut()) statement, also adjusted firstmonId and lastmonId to stay between the boundaries of each player (0-2 PLAYER, 3-5 STEVEN)

Description

#2093 Fixes

Discord contact info

Shachar700

[mrgriffin]

This is going to need #ifdef BUGFIX...#endifs around it, because it doesn't match as-is.

[mrgriffin]

Without the fix is it possible for my Pokémon to get switched with one of Steven's or does the bug only manifest in the party screen? How would you recommend to test the fix?

[shachar700]

I recommend to test the fix by:

• Getting 3 different pokemon
• Putting a sign in littleroot town with the script "MossdeepCity_SpaceCenter_2F_EventScript_ChoosePartyForMultiBattle"
• Giving the opponent switchout moves (roar, whirlwind, etc...)
  Check pokemon summary screen after every turn.

The fix fixes the case where mightyena is on your side of the field.
And also the order of the pokemon in the summary screen not getting scrambled with steven's slots.