Refactor all uses of GEN_FCN to use locals #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(addresses #43) |
An intermediate local value for lookups in the instruction generation jump table works around a code generation bug in macOS ARM64 clang that would cause their parameters to be pushed on the stack instead of passed in registers.
|
I've had feedback on the pret Discord server that this works and people are able to build projects such as Further research indicates that both vanilla Clang and gcc are also affected, so this might be a more general ABI problem. Either way, the issue is fixed by these changes; it's a matter of if they're acceptable to merge given the extent of them. |
|
I've recently found some documentation indicating these may be consequences of deliberate changes made to the ARM64 ABI on Apple platforms: https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms#Update-Code-that-Passes-Arguments-to-Variadic-Functions |
laqieer
added a commit
to laqieer/fireemblem8u
that referenced
this pull request
Mar 23, 2023
You needn't to build holmesmr's fork of agbcc on Mac because that fix for Mac has been merged in pret/agbcc#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An intermediate local value (cast to the appropriate signature) for lookups in the instruction generation jump table works around a code generation bug in macOS ARM64 clang that would cause their parameters to be pushed on the stack instead of passed in registers.