Add Symfony 7.2 and PHP 8.4 to test matrix

[ker0x]

No description provided.

[yann-eugone]

Hello, thank you for your contribution

IMO, that's a lot for a single PR
Probably too much

[ker0x]

Hello @yann-eugone, thank you for your feedback !

I reduce the PR to only add Symfony 7.2 and PHP 8.4 to the test matrix! I will submit others PRs for the rest.

[MonsieurV]

Hi, I second this PR for the types annotations. I started getting deprecation warnings after switching to PHP8.4.

One example:

Deprecated: Presta\SitemapBundle\Event\SitemapPopulateEvent::__construct(): Implicitly marking parameter $section as nullable is deprecated, the explicit nullable type must be used instead

[yann-eugone]

Hi @MonsieurV

Please feel free to open an issue or a PR on this topic

[MonsieurV]

Hi @MonsieurV

Please feel free to open an issue or a PR on this topic

Hi @yann-eugone,

I've read the submitted code by @ker0x, and it solves all the deprecations for PHP8.4 (by adding the typing annotation ?). Well, except in test code, but I think maybe he may add these last annotations to complete this PR (then all the tests should run).

See
https://github.com/prestaconcept/PrestaSitemapBundle/actions/runs/12446059174/job/35187492070?pr=351#step:5:22
for the last deprecations to fix in test code.

[yann-eugone]

Fine then, but at the moment this PR cannot be merged, due to the fact that it breaks all the tests

[ker0x]

@yann-eugone I just push some changes! Can you check them please?

[yann-eugone]

Thanks for your help 🙏