Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(l10n): update languages/pressbooks-saml-sso.pot #122

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

Automated changes by create-pull-request GitHub action

@SteelWagstaff
Copy link
Member

@greatislander here's the resulting PR from new update POT command. I'm a bit surprised that the blade template strings are removed, as I thought that WP CLI 2.3.0 added support for Blade templates (see wp-cli/i18n-command#304 (comment)). Can you help us understand what we might need to change so that these strings are preserved?

@strarsis
Copy link

@SteelWagstaff: Probably because the wp i18n release was used instead where the Blade-PHP support wasn't added yet.

@SteelWagstaff
Copy link
Member

Thanks @strarsis! We ended up solving this with #125 -- it was just as you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants