Skip to content

Conversation

mvanderkamp
Copy link
Member

@mvanderkamp mvanderkamp commented Oct 14, 2025

With tmux list-panes -a we can get all panes across all windows and sessions, allowing us to precisely track our runner no matter where it is. But to do this we need to make g:VimuxRunnerIndex always be the pane ID.

This will be a breaking change for any Window runner users who have crafted custom configuration or scripts that modify g:VimuxRunnerIndex. I'm going to spend some time thinking about whether there's a way to keep supporting the old functionality, but I'd like to have this code sitting here for comment in the meantime.

@mvanderkamp mvanderkamp requested a review from Copilot October 14, 2025 06:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors Vimux to consistently use tmux pane IDs as runner identifiers instead of using different types (pane ID vs window ID) based on the runner type. This simplifies runner tracking by leveraging tmux list-panes -a to find panes across all windows and sessions.

  • Removes the conditional logic that switched between pane IDs and window IDs based on runner type
  • Introduces a new s:selectRunner() function that handles both window and pane selection uniformly
  • Simplifies the s:hasRunner() function to only check for pane existence using list-panes -a

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant