remove big deps #90
Merged
remove big deps #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also do a wrapper since we are using both |
| _.extend(@, Backbone.Events) | ||
|
|
||
| #sqwidget level event bus | ||
| @ee = new EventEmitter() |
There was a problem hiding this comment.
How will this work for inter-widget communication?
There was a problem hiding this comment.
core is only initialised once, widgets are registered against this instance.
On Thu, Oct 17, 2013 at 11:31 AM, Adhip Gupta [email protected]:
In src/component/core.coffee:
class SqwidgetCore
constructor: () ->
_.extend(@, Backbone.Events)
#sqwidget level event bus@ee = new EventEmitter()How will this work for inter-widget communication?
?
Reply to this email directly or view it on GitHubhttps://github.com//pull/90/files#r7028563
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built sqwidget is now 25k with everything included.