Strip single-line javascript comments from the html template before generation #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They prevent it from working. The stripper is really dumb and considers anything two-forward slashes following a space to be a comment. You'd need a full blown parser to deal with comments, especially multiline, correctly.
premasagar
added a commit
that referenced
this pull request
Apr 3, 2013
Strip single-line javascript comments from the html template before generation
|
Thanks Jay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They prevent the generated js file from working.
The stripper is really dumb and considers anything after two-forward slashes following a space to be a comment. You'd need a full blown parser to deal with comments, especially multiline, correctly.