-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/optimize #104
Feature/optimize #104
Conversation
purge
commented
Nov 11, 2013
- Optimized build.
- Accepts AMD or promise based module loader.
- Created nested structure from config options.
- Update core dependencies.
- Everything loaded in its own context
- Support pre-loading of plugins as mixins to main bundles.
- Tests
* remove global
//bus events | ||
bean.fire(this, "rendered:" + pkg.location); | ||
bean.fire(this, "rendered:" + pkg.id); | ||
bean.fire(pkg, "rendered"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namespacing using dots?
And in that case, do we need the last one?
}, | ||
//optimize: 'uglify2', | ||
optimize: 'none', | ||
preserveLicenseComments: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smaller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it makes using the libraries illegal with certain licenses.
…undles into context
This needs |
], function(require, strings, css, template ) { | ||
return { | ||
Controller: function(opts) { | ||
this.view = new Ractive({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Ractive is now a dependency of sqwidget as a whole?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is just the scaffold
—
Sent from Mailbox for iPhone
On Wed, Nov 13, 2013 at 6:06 PM, Adhip Gupta [email protected]
wrote:
@@ -0,0 +1,16 @@
+define([
- 'require',
- 'i18n!./nls/strings',
- 'css!compiled/css/main.css',
- 'rv!templates/index.html'
+], function(require, strings, css, template ) {- return {
- Controller: function(opts) {
this.view = new Ractive({
Is Ractive is now a dependency of sqwidget as a whole?
Reply to this email directly or view it on GitHub:
https://github.com/premasagar/sqwidget/pull/104/files#r7634479
The README.md file is outdated and obsolete. Can we please have one that corresponds to this version? |
Warnings about missing |
Please remove the default task in Gruntfile.js. It's just confusing and obsolete. |