Before after and focus #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 4, 2018 15:58
…ver, focus, visited and active psudoclasses
|
It seems like many selectors were removed from different places instead of just new stuff added. Why were they removed? Also seems to be a few lines with extra whitespace added at the end. |
|
I don't think that I removed any selectors, though, I may have inserted some into the middle of a line. Do you have an example of something that was removed? As for the whitespaces, yeah, that was my bad. |
|
This would be a great addition. |
ddelrio1986
reviewed
Jun 12, 2018
|
|
||
| /* HTML5 - Sept 2013 taken from MDN https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/HTML5_element_list */ | ||
| .cleanslate article, .cleanslate aside, .cleanslate figure, .cleanslate figcaption, .cleanslate footer, .cleanslate header, .cleanslate menu, .cleanslate nav, .cleanslate section, .cleanslate time, .cleanslate mark, .cleanslate audio, .cleanslate video, .cleanslate abbr, .cleanslate address, .cleanslate area, .cleanslate blockquote, .cleanslate canvas, .cleanslate caption, .cleanslate cite, .cleanslate code, .cleanslate colgroup, .cleanslate col, .cleanslate datalist, .cleanslate fieldset, .cleanslate main, .cleanslate map, .cleanslate meta, .cleanslate optgroup, .cleanslate output, .cleanslate progress, .cleanslate svg { | ||
| .cleanslate article, .cleanslate aside, .cleanslate figure, .cleanslate figcaption, .cleanslate footer, .cleanslate header, .cleanslate menu, .cleanslate nav, .cleanslate section, .cleanslate time, .cleanslate mark, .cleanslate audio, .cleanslate video, .cleanslate abbr, .cleanslate address, .cleanslate area, .cleanslate blockquote, .cleanslate canvas, .cleanslate caption, .cleanslate cite, .cleanslate code, .cleanslate colgroup, .cleanslate col, .cleanslate datalist, .cleanslate fieldset, .cleanslate main, .cleanslate map, .cleanslate meta, .cleanslate optgroup, .cleanslate output, .cleanslate progress, .cleanslate *:before, .cleanslate *:after { |
| @@ -257,7 +259,7 @@ | |||
| .cleanslate em { | |||
| font-style:italic !important; | |||
| } | |||
| .cleanslate kbd, .cleanslate samp, .cleanslate code, .cleanslate pre { | |||
| .cleanslate kbd, .cleanslate samp, .cleanslate code { | |||
| @@ -267,7 +269,7 @@ | |||
| .cleanslate a:visited { | |||
| color: #529 !important; | |||
| } | |||
| .cleanslate a, .cleanslate a *, .cleanslate input[type=submit], .cleanslate input[type=button], .cleanslate input[type=radio], .cleanslate input[type=checkbox], .cleanslate select, .cleanslate button { | |||
| .cleanslate a, .cleanslate a *, .cleanslate a:hover, .cleanslate a:focus, .cleanslate input[type=submit], .cleanslate input[type=radio], .cleanslate input[type=checkbox], .cleanslate select { | |||
There was a problem hiding this comment.
.cleanslate input[type=button] and .cleanslate button was removed here.
| @@ -354,6 +346,16 @@ | |||
| .cleanslate input[type=radio] { | |||
| margin: 2px 2px 3px 2px !important; | |||
| } | |||
| .cleanslate input[type=submit]:active, .cleanslate button:active { | |||
There was a problem hiding this comment.
.cleanslate input[type=button]:active and .cleanslate button:active were removed here.
| @@ -447,7 +455,3 @@ | |||
| text-decoration:none !important; | |||
| list-style-type:disc !important; | |||
| } | |||
|
|
|||
|
Thanks for the pull request. Yes it looks like there were a couple of accidental deletions. And it looks like the version number has been changed. If you could fix those, I'd be happy to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to clear before and after for all elements as well as link hover, active, etc. pseudo classes.