Skip to content

Conversation

@my1e5
Copy link
Contributor

@my1e5 my1e5 commented Oct 16, 2025

This PR adds a py.typed to the tsdownsample directory. This allows type checkers like mypy to support type checking.

Closes #86

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (05334d5) to head (6aeafa6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #90   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          4       4           
  Lines        371     371           
=====================================
  Misses       371     371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025

CodSpeed Performance Report

Merging #90 will degrade performances by 24.95%

Comparing my1e5:typing-support (6aeafa6) with main (db142fa)

Summary

⚡ 8 improvements
❌ 8 regressions
✅ 662 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_m4_no_x[True-float32-100-100,000] 415.6 µs 484 µs -14.13%
test_m4_with_x[True-float32-1,000-100,000] 1.8 ms 1.5 ms +17.68%
test_minmax_no_x[True-float32-1,000-100,000] 529.1 µs 455.3 µs +16.2%
test_minmax_no_x[True-int32-100-100,000] 631 µs 547.2 µs +15.33%
test_minmax_with_x[True-float64-1,000-100,000] 1.9 ms 2.2 ms -14.2%
test_minmax_with_x[True-int64-1,000-100,000] 1.9 ms 2.3 ms -18.39%
test_minmaxlttb_with_x[True-int64-1,000-100,000] 4.4 ms 5.2 ms -14.58%
test_nanm4_no_x[True-float32-100-100,000] 434.1 µs 394.6 µs +10.01%
test_nanm4_with_x[True-float32-1,000-100,000] 1.3 ms 1.5 ms -10.21%
test_nanm4_with_x[True-int32-1,000-100,000] 1.5 ms 1.9 ms -20.94%
test_nanminmax_no_x[True-float32-100-100,000] 472.2 µs 416.8 µs +13.29%
test_nanminmax_with_x[True-float32-1,000-1,000,000] 4 ms 3.6 ms +11.85%
test_nanminmax_with_x[True-float32-1,000-100,000] 1.5 ms 1.9 ms -24.95%
test_nanminmax_with_x[True-int32-1,000-1,000,000] 4.6 ms 3.7 ms +23.98%
test_nanminmax_with_x[True-int32-1,000-100,000] 2 ms 1.6 ms +27.87%
test_nanminmaxlttb_no_x[True-float32-1,000-100,000] 784.6 µs 881 µs -10.95%

@s4m0r4m4
Copy link

Thanks!

@jvdd jvdd merged commit cdb7094 into predict-idlab:main Oct 16, 2025
43 of 44 checks passed
@my1e5 my1e5 deleted the typing-support branch October 20, 2025 10:45
@s4m0r4m4
Copy link

Do we know when a release will be made with this improvement?

@my1e5
Copy link
Contributor Author

my1e5 commented Oct 22, 2025

Do we know when a release will be made with this improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mypy typing support

4 participants