Add category filter for organization logos on the landing page#842
Add category filter for organization logos on the landing page#842Shaurya8425 wants to merge 8 commits intoprecice:masterfrom
Conversation
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
from
2fe2eeb to
303e8a8
Compare
|
@Shaurya8425 thanks! |
|
@hanzalahwaheed |
|
pure llm coded poor code pls do as less code changes so it will be helpful for maintainers |
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
from
303e8a8 to
a24f022
Compare
|
@smackcodernight Thanks for the feedback! I've updated the PR with minimal manual changes — only adding the category field to each entry in logowall.yml and the necessary JS/CSS for the filter. The diff should be much cleaner now. |
|
@Shaurya8425 The feature looks good. One suggestion: when a field is selected, it could move to the top instead of just being hidden. Also, the selected org logos could appear one after another |
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
from
ce02cfc to
a61ff89
Compare
|
@praaatap Thanks for the suggestions! I’ve pushed the reordering to the top. Kept out stagger animation to stay consistent with the minimal style of the site - happy to add if u think it fits!” |
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
2 times, most recently
from
655a029 to
a36bf90
Compare
- Add filter buttons (All/Academic/Research/Industry) - Add category metadata to logowall.yml - Implement client-side filtering with landing-page.js - Style filter buttons with hover and active states
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
from
a36bf90 to
aec5fdd
Compare
MakisH
added
GSoC
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/introduction-shaurya-yadav/2832/1 |
There was a problem hiding this comment.
Thank you for contributing, @Shaurya8425. This is a nice idea! I thought I could directly fix a few issues, and I pushed a few commits, but this still has issues in narrow screens: the logos overlap, and the button at the bottom has no margin from the left, even though it is still inside a container and section, as other parts of the page.
In the current version, each row just gets fewer elements. Why do you need the new logowall-grid class? If you can reuse the same classes as before, there would be no issue.
Are you still up for following up on this PR?
MakisH
changed the title
|
Thank you for acknowledging @MakisH. I've pushed changes as per your comment. I'm also attaching a video addressing good responsiveness in smaller screens. Screen.Recording.2026-05-08.220409.mp4 |
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Thanks for the updates, @Shaurya8425! Looks already closer to the current version.
There are still a few unrelated/unmotivated changes, see my inline comments. Overall, I would prefer that this PR only adds what it needs for the feature to work, not change which other classes the code uses (at least not without a clear need to do so).
| <div class="col-md-3 col-sm-3 col-xs-3 text-center"> <!-- vertical-align --> | ||
| <a href="{{logo.link}}" class="logo no-icon"> | ||
| <div class="logo-holder vertical-align "> <!-- center-block --> | ||
| <img class="img-responsive center-block" src="images/logo/{{logo.logo}}" alt="{{logo.name}}, {{logo.country}}" |
There was a problem hiding this comment.
Why removing the center-block class?
| {% for column in row.columns %} | ||
| <div class="col-md-6 col-xs-12 no-padding"> | ||
| {% for logo in column.logos %} | ||
| <div class="col-md-3 col-sm-3 col-xs-3 text-center"> <!-- vertical-align --> |
There was a problem hiding this comment.
Why removing the text-center class?
|
|
||
| <div class="row logowall-grid"> | ||
| {% for row in logowall %} | ||
| <div class="row no-margin"> |
There was a problem hiding this comment.
Why removing the no-margin class?
| {% for row in logowall %} | ||
| <div class="row no-margin"> | ||
| {% for column in row.columns %} | ||
| <div class="col-md-6 col-xs-12 no-padding"> |
|
Hey @MakisH, the answer to most of the changes for which you have left the comments is because they were making the text smudged on choosing smaller screen devices. It's quite visible in production. When they're left aligned, given no margin as per the new changes. It doesn't cause such issue. |
6 participants
What
Add category filter buttons (All/Academic/Research/Industry) to the
organization logos section on the landing page.
Why
Makes it easier for visitors to find organizations by type.
Changes