Skip to content

Bid Adjustment: Upgrade matching strategy #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sigma-software-prebid wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bid Adjustment: Upgrade matching strategy #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 50 additions & 18 deletions bidadjustment/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package bidadjustment

import (
"math"
"strings"

"github.com/prebid/prebid-server/v3/adapters"
"github.com/prebid/prebid-server/v3/openrtb_ext"
Expand All @@ -15,15 +16,15 @@ const (
Delimiter = "|"
)

const maxNumOfCombos = 8
const maxNumOfCombos = 12
const pricePrecision float64 = 10000 // Rounds to 4 Decimal Places
const minBid = 0.1

// Apply gets the highest priority adjustment slice given a map of rules, and applies those adjustments to a bid's price
func Apply(rules map[string][]openrtb_ext.Adjustment, bidInfo *adapters.TypedBid, bidderName openrtb_ext.BidderName, currency string, reqInfo *adapters.ExtraRequestInfo, bidType string) (float64, string) {
var adjustments []openrtb_ext.Adjustment
if len(rules) > 0 {
adjustments = get(rules, bidType, string(bidderName), bidInfo.Bid.DealID)
adjustments = get(rules, bidType, string(bidInfo.Seat), string(bidderName), bidInfo.Bid.DealID)
} else {
return bidInfo.Bid.Price, currency
}
Expand Down Expand Up @@ -67,27 +68,58 @@ func apply(adjustments []openrtb_ext.Adjustment, bidPrice float64, currency stri
// get() should return the highest priority slice of adjustments from the map that we can match with the given bid info
// given the bid info, we create the same format of combinations that's present in the key of the ruleToAdjustments map
// the slice is ordered by priority from highest to lowest, as soon as we find a match, we return that slice
func get(rules map[string][]openrtb_ext.Adjustment, bidType, bidderName, dealID string) []openrtb_ext.Adjustment {
func get(rules map[string][]openrtb_ext.Adjustment, bidType, seat, bidderName, dealID string) []openrtb_ext.Adjustment {
priorityRules := [maxNumOfCombos]string{}
if dealID != "" {
priorityRules[0] = bidType + Delimiter + bidderName + Delimiter + dealID
priorityRules[1] = bidType + Delimiter + bidderName + Delimiter + WildCard
priorityRules[2] = bidType + Delimiter + WildCard + Delimiter + dealID
priorityRules[3] = WildCard + Delimiter + bidderName + Delimiter + dealID
priorityRules[4] = bidType + Delimiter + WildCard + Delimiter + WildCard
priorityRules[5] = WildCard + Delimiter + bidderName + Delimiter + WildCard
priorityRules[6] = WildCard + Delimiter + WildCard + Delimiter + dealID
priorityRules[7] = WildCard + Delimiter + WildCard + Delimiter + WildCard

// lowercase the parameter to make the rules it case insensitive
bidType = strings.ToLower(bidType)
bidderName = strings.ToLower(bidderName)
dealID = strings.ToLower(dealID)
seat = strings.ToLower(seat)

if seat != "" {
if dealID != "" {
priorityRules[0] = bidType + Delimiter + seat + Delimiter + dealID // type|seat|dealID
priorityRules[1] = bidType + Delimiter + bidderName + Delimiter + dealID // type|bidder|dealID
priorityRules[2] = bidType + Delimiter + seat + Delimiter + WildCard // type|seat|*
priorityRules[3] = bidType + Delimiter + bidderName + Delimiter + WildCard // type|bidder|*
priorityRules[4] = bidType + Delimiter + WildCard + Delimiter + dealID // type|*|dealID
priorityRules[5] = WildCard + Delimiter + seat + Delimiter + dealID // *|seat|dealID
priorityRules[6] = WildCard + Delimiter + bidderName + Delimiter + dealID // *|bidder|dealID
priorityRules[7] = bidType + Delimiter + WildCard + Delimiter + WildCard // type|*|*
priorityRules[8] = WildCard + Delimiter + seat + Delimiter + WildCard // *|seat|*
priorityRules[9] = WildCard + Delimiter + bidderName + Delimiter + WildCard // *|bidder|*
priorityRules[10] = WildCard + Delimiter + WildCard + Delimiter + dealID // *|*|dealID
priorityRules[11] = WildCard + Delimiter + WildCard + Delimiter + WildCard // *|*|*
} else {
priorityRules[0] = bidType + Delimiter + seat + Delimiter + WildCard // type|seat|*
priorityRules[1] = bidType + Delimiter + bidderName + Delimiter + WildCard // type|bidder|*
priorityRules[2] = bidType + Delimiter + WildCard + Delimiter + WildCard // type|*|*
priorityRules[3] = WildCard + Delimiter + seat + Delimiter + WildCard // *|seat|*
priorityRules[4] = WildCard + Delimiter + bidderName + Delimiter + WildCard // *|bidder|*
priorityRules[5] = WildCard + Delimiter + WildCard + Delimiter + WildCard // *|*|*
}
} else {
priorityRules[0] = bidType + Delimiter + bidderName + Delimiter + WildCard
priorityRules[1] = bidType + Delimiter + WildCard + Delimiter + WildCard
priorityRules[2] = WildCard + Delimiter + bidderName + Delimiter + WildCard
priorityRules[3] = WildCard + Delimiter + WildCard + Delimiter + WildCard
if dealID != "" {
priorityRules[0] = bidType + Delimiter + bidderName + Delimiter + dealID // type|bidder|dealID
priorityRules[1] = bidType + Delimiter + bidderName + Delimiter + WildCard // type|bidder|*
priorityRules[2] = bidType + Delimiter + WildCard + Delimiter + dealID // type|*|dealID
priorityRules[3] = WildCard + Delimiter + bidderName + Delimiter + dealID // *|bidder|dealID
priorityRules[4] = bidType + Delimiter + WildCard + Delimiter + WildCard // type|*|*
priorityRules[5] = WildCard + Delimiter + bidderName + Delimiter + WildCard // *|bidder|*
priorityRules[6] = WildCard + Delimiter + WildCard + Delimiter + dealID // *|*|dealID
priorityRules[7] = WildCard + Delimiter + WildCard + Delimiter + WildCard // *|*|*
} else {
priorityRules[0] = bidType + Delimiter + bidderName + Delimiter + WildCard // type|bidder|*
priorityRules[1] = bidType + Delimiter + WildCard + Delimiter + WildCard // type|*|*
priorityRules[2] = WildCard + Delimiter + bidderName + Delimiter + WildCard // *|bidder|*
priorityRules[3] = WildCard + Delimiter + WildCard + Delimiter + WildCard // *|*|*
}
}

for _, rule := range priorityRules {
if _, ok := rules[rule]; ok {
return rules[rule]
if matchingRule, ok := rules[rule]; ok {
return matchingRule
}
}
return nil
Expand Down
Loading
Loading