Core: Added src field to client bidRequests to ensure consistent payload structure #14301
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review-assignment-bot
bot
requested review from
jlquaccia and
robertrmartinez
Collaborator
|
@anastasiiapankivFS please add some unit tests to cover this also! |
patmmccann
changed the title
patmmccann
requested review from
dgirardi
and removed request for
robertrmartinez
dgirardi
approved these changes
Jan 15, 2026
patmmccann
reviewed
Jan 15, 2026
| timeout: cbTimeout, | ||
| refererInfo, | ||
| metrics, | ||
| src: 'client', |
Collaborator
There was a problem hiding this comment.
isn't it on line 651 above? why have it at both levels?
Collaborator
Pull Request Test Coverage Report for Build 21043378589Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When constructing server side bidRequests
srcis set on both bidRequest and bid level VS for client sidesrcis only set on a bid level.This PRs ensures
srcfield is consistently populated.