Reduce Preact prop updater allocations - #978
Closed
JoviDeCroock wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: eef7237 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: -6.94 kB (-3.35%) Total Size: 200 kB 📦 View Changed
ℹ️ View Unchanged
|
Member
Author
|
Byte size impact is a bit too large |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each signal-bound DOM property currently allocates a wrapper object, updater closure, effect callback closure, and bound disposer. Make the Effect itself the property updater and share its callback and update methods across bindings, while retaining the wrapper Signal that preserves rebinding semantics.
Trade-off: signals.mjs grows from 1732 B to 1821 B gzip (+89 B). Each live binding is 72 B smaller, so the shipped cost breaks even after a few bound properties.
Signal-bound DOM properties — 52.5% faster creation, 72 B smaller, 11.1% faster updates