Optimize computed reads and snapshot allocation in batches - #971
Draft
JoviDeCroock wants to merge 3 commits into
Draft
Optimize computed reads and snapshot allocation in batches#971JoviDeCroock wants to merge 3 commits into
JoviDeCroock wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: c2e767d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: +1.66 kB (+0.8%) Total Size: 209 kB 📦 View Changed
ℹ️ View Unchanged
|
JoviDeCroock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse batch snapshot nodes and skip snapshots for unobserved signals, eliminating steady-state snapshot allocation while preserving no-op batch reconciliation.
For lazy computed graphs read after writes in a batch, maintain an internal batch-lifetime notification graph so subsequent writes invalidate only affected paths without creating user-visible subscriptions.
Six-round CPU medians against the prior PR head improved
large web appby 83.1% andwide denseby 64.7% with identical sums and computation counts, with coverage for dynamic dependencies, self-invalidation, watcher isolation, and exception cleanup.Validation:
pnpm build,pnpm lint,pnpm test(1,352 passed; 5 skipped),pnpm test:prod(1,352 passed; 5 skipped), and a 100-round differential stress test against the prior implementation.