Skip to content

Fix settings popover actions - #962

Merged
JoviDeCroock merged 1 commit into
mainfrom
jdv/fix-settings-cancel-overlay
Jul 23, 2026
Merged

Fix settings popover actions#962
JoviDeCroock merged 1 commit into
mainfrom
jdv/fix-settings-cancel-overlay

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Problem

The settings popover remained open after Cancel, and Apply offered no visible completion feedback.

Solution

Use the native popover API to close the settings panel after either action while preserving setting application.

Assisted-By: devx/5759b8ac-88b1-4e56-ba0c-25bf9c04d673
@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 05bb87e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@preact/signals-devtools-ui Patch
preact-signals-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 05bb87e
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/6a60cb831bd3ea000826ccc8
😎 Deploy Preview https://deploy-preview-962--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

Size Change: +698 B (+0.38%)

Total Size: 183 kB

📦 View Changed
Filename Size Change
docs/dist/assets/bench-********.js 1.6 kB +1 B (+0.06%)
docs/dist/assets/EmbeddedDevtools-********.js 17.9 kB +16 B (+0.09%)
docs/dist/assets/index-********.js 1.21 kB +665 B (+122.69%) 🆘
packages/devtools-ui/dist/devtools-ui.js 16.3 kB +6 B (+0.04%)
packages/devtools-ui/dist/devtools-ui.mjs 15.7 kB +10 B (+0.06%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client-********.js 46.6 kB
docs/dist/assets/devtools-********.js 912 B
docs/dist/assets/jsxRuntime.module-********.js 300 B
docs/dist/assets/preact.module-********.js 4.74 kB
docs/dist/assets/signals-core.module-********.js 1.92 kB
docs/dist/assets/signals.module-********.js 2.65 kB
docs/dist/assets/style-********.css 5.26 kB
docs/dist/assets/Unmount-********.js 652 B
docs/dist/assets/utils.module-********.js 516 B
docs/dist/basic-********.js 250 B
docs/dist/nesting-********.js 1.15 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.94 kB
packages/core/dist/signals-core.mjs 1.93 kB
packages/debug/dist/debug.js 4.64 kB
packages/debug/dist/debug.mjs 4.15 kB
packages/devtools-adapter/dist/devtools-adapter.js 2.36 kB
packages/devtools-adapter/dist/devtools-adapter.mjs 2.07 kB
packages/preact-transform/dist/signals-transform.js 1.69 kB
packages/preact-transform/dist/signals-transform.mjs 1.64 kB
packages/preact-transform/dist/signals-transform.umd.js 1.8 kB
packages/preact/dist/signals.js 1.81 kB
packages/preact/dist/signals.mjs 1.74 kB
packages/react-transform/dist/signals-transform.js 7.65 kB
packages/react-transform/dist/signals-transform.mjs 6.8 kB
packages/react-transform/dist/signals-transform.umd.js 7.77 kB
packages/react/dist/signals.js 214 B
packages/react/dist/signals.mjs 165 B
packages/vite-plugin/dist/vite-plugin.js 8.86 kB
packages/vite-plugin/dist/vite-plugin.mjs 7.86 kB

compressed-size-action

@JoviDeCroock
JoviDeCroock merged commit ee06f32 into main Jul 23, 2026
6 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 23, 2026
@JoviDeCroock
JoviDeCroock deleted the jdv/fix-settings-cancel-overlay branch July 23, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants