Fix #264 Preact Router is not able to be extended #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add setCustomHistory function, because customHistory is read-only when exports. Router class now extendable, to extend it - simple copy its constructor without "Object.getPrototypeOf" condition. Add export for canRoute, delegateLinkHandler, routeTo, customHistory, setCustomHistory.
moebiusmania
approved these changes
Feb 10, 2018
developit
reviewed
Feb 11, 2018
| customHistory = props.history; | ||
| } | ||
| /** this condition allows to modify the constructor */ | ||
| if (Object.getPrototypeOf(this.constructor).name === 'Component') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #264
Add setCustomHistory function, because customHistory is read-only when exports.
Router class now extendable, to extend it - simple copy its constructor without "Object.getPrototypeOf" condition.
Add export for canRoute, delegateLinkHandler, routeTo, customHistory, setCustomHistory.