Skip to content

Conversation

@rschristian
Copy link
Member

@rschristian rschristian commented Oct 25, 2025

The test suite is a bit difficult to traverse at the moment, largely due to similar tests not being grouped together and different test cases sharing CE definitions, creating unclear dependencies. This PR looks to improve that situation whilst also adding a handful of tests for missing cases (which are now more obvious due to the reorganization).

  • Creates a dedicated test module for the options bag, adding a couple extra tests
  • Creates a dedicated test module for static properties, adding a few new tests
  • Moves most CE registrations/definitions into the consuming test case
    • These are technically global, but stops us from trying to share across test cases so readily which is, IMO, problematic when making changes

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

Size Change: 0 B

Total Size: 4.11 kB

ℹ️ View Unchanged
Filename Size
dist/preact-custom-element.esm.js 1.36 kB
dist/preact-custom-element.js 1.34 kB
dist/preact-custom-element.umd.js 1.41 kB

compressed-size-action

@rschristian rschristian marked this pull request as ready for review October 30, 2025 03:07
@rschristian rschristian merged commit c6d239e into master Oct 30, 2025
2 checks passed
@rschristian rschristian deleted the test/refactor-suite branch October 30, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants