Replace play-services-ads dep with play-services-ads-identifier #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fier As of v17.0.0 of the play-services-ads library there is an additional requirement to specify com.google.android.gms.ads.APPLICATION_ID in the AndroidManifest.xml: https://stackoverflow.com/questions/25061107/advertisingidclient-without-google-play-services This plugin actually only needs play-services-ads-identifier in order to get an advertising ID, so if we make our dependencies more precise we can avoid this unnecessary requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v17.0.0 of the play-services-ads library there is an
additional requirement to specify com.google.android.gms.ads.APPLICATION_ID
in the AndroidManifest.xml:
https://stackoverflow.com/questions/25061107/advertisingidclient-without-google-play-services
This plugin actually only needs play-services-ads-identifier in
order to get an advertising ID, so if we make our dependencies
more precise we can avoid this unnecessary requirement.