First pass at tracking system metrics #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spawns a background thread to track common system metrics; currently only tracks a few, but we can add more as needed. I evaluated a few different metrics: - [opentelemetry-system-metrics](https://crates.io/crates/opentelemetry-system-metrics) - [sys_metrics](https://crates.io/crates/sys_metrics) - [heim](https://github.com/heim-rs/heim?tab=readme-ov-file) Of these, sys_metrics doesn't support windows, but is the most actively maintained. As a follow up, it might be useful to track Tokio runtime metrics as well: https://docs.rs/tokio/latest/tokio/runtime/struct.RuntimeMetrics.html
|
Example view in grafana: I should also note that this follows naming conventions as specified here: https://opentelemetry.io/docs/specs/semconv/general/metrics/#general-metric-semantic-conventions |
Quantumplation
force-pushed
the
pi/sys-metrics
branch
from
c66cfbd to
32e8d9e
Compare
|
Do we want to track system-level metrics from within the process? Would it not be simpler and more flexible to let the users reap those from the underlying system, using whatever makes sense for them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spawns a background thread to track common system metrics; currently only tracks a few, but we can add more as needed.
I evaluated a few different metrics:
Of these, sys_metrics doesn't support windows, but is the most actively maintained.
As a follow up, it might be useful to track Tokio runtime metrics as well:
https://docs.rs/tokio/latest/tokio/runtime/struct.RuntimeMetrics.html
Opening this as a draft PR, looking for feedback on the structure / organization before I write a few more tests and add a few more metrics.