Setup the build environment, basic scaffolding, and block validation (minus KES) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewWestberg
force-pushed
the
amw/build_setup
branch
from
cd157eb to
fa97324
Compare
AndrewWestberg
force-pushed
the
amw/build_setup
branch
5 times, most recently
from
acea888 to
0f1a7f6
Compare
AndrewWestberg
force-pushed
the
amw/build_setup
branch
from
0f1a7f6 to
89504e2
Compare
AndrewWestberg
force-pushed
the
amw/build_setup
branch
from
89504e2 to
733a992
Compare
scarmuega
reviewed
Oct 1, 2024
Comment on lines
+19
to
+29
| let tracing_filter = match var("RUST_LOG") { | ||
| Ok(level) => match level.to_lowercase().as_str() { | ||
| "error" => tracing::Level::ERROR, | ||
| "warn" => tracing::Level::WARN, | ||
| "info" => tracing::Level::INFO, | ||
| "debug" => tracing::Level::DEBUG, | ||
| "trace" => tracing::Level::TRACE, | ||
| _ => tracing::Level::INFO, | ||
| }, | ||
| Err(_) => tracing::Level::INFO, | ||
| }; |
There was a problem hiding this comment.
we could probably use the following instead of manual mapping:
https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#
scarmuega
reviewed
Oct 1, 2024
| @@ -0,0 +1,20 @@ | |||
| [package] | |||
| name = "amaru-node" | |||
There was a problem hiding this comment.
I agree with @rvcas here, calling the node just amaru seems reasonable (unless we're thinking on treating this crate as a library, which I don't think it's the case).
|
Refactoring to move many things into ouroboros repository. closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KES validation can come in a future PR.