Skip to content

Conversation

@potsrevennil
Copy link
Contributor

@potsrevennil potsrevennil commented Feb 26, 2025

Summary:
workflow triggered by workflow_run wont be rendered in a PR, which is not ideal.
We should probably go with resuing workflows instead

Steps:
If your pull request consists of multiple sequential changes, please describe them here:

Performed local tests:

  • lint passing
  • tests all passing
  • tests bench passing
  • tests cbmc passing

Do you expect this change to impact performance: Yes/No

If yes, please provide local benchmarking results.

This reverts commit 4174800, reversing
changes made to 79c6b92.

Signed-off-by: Hanno Becker <[email protected]>
@hanno-becker hanno-becker force-pushed the revert-workflow-run branch 13 times, most recently from 5548ce9 to af1d92b Compare February 27, 2025 05:50
Preparation for a subsequent commit calling them from base.yml.

Signed-off-by: Hanno Becker <[email protected]>
@mkannwischer mkannwischer marked this pull request as ready for review February 27, 2025 05:52
@mkannwischer mkannwischer requested a review from a team as a code owner February 27, 2025 05:52
@hanno-becker hanno-becker merged commit 2f62dd2 into main Feb 27, 2025
180 checks passed
@hanno-becker hanno-becker deleted the revert-workflow-run branch February 27, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants