Add AWS-LC integration test #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hanno-becker
force-pushed
the
aws_lc_integration
branch
3 times, most recently
from
b814b55 to
9f0037d
Compare
hanno-becker
force-pushed
the
aws_lc_integration
branch
from
9f0037d to
cc89f23
Compare
hanno-becker
changed the title
hanno-becker
force-pushed
the
aws_lc_integration
branch
2 times, most recently
from
c12e6fb to
076d65a
Compare
hanno-becker
force-pushed
the
aws_lc_integration
branch
from
076d65a to
730116b
Compare
hanno-becker
force-pushed
the
aws_lc_integration
branch
2 times, most recently
from
414b211 to
0eb614f
Compare
hanno-becker
changed the title
hanno-becker
force-pushed
the
aws_lc_integration
branch
10 times, most recently
from
744fe93 to
a6e16d6
Compare
hanno-becker
force-pushed
the
aws_lc_integration
branch
9 times, most recently
from
8723b62 to
c5b081a
Compare
hanno-becker
force-pushed
the
aws_lc_integration
branch
6 times, most recently
from
c26c178 to
c9ff9ce
Compare
hanno-becker
force-pushed
the
aws_lc_integration
branch
2 times, most recently
from
ae08bf6 to
2f072a2
Compare
hanno-becker
force-pushed
the
aws_lc_integration
branch
2 times, most recently
from
28c07ff to
f5704d6
Compare
This commit extends the CI with an integration test for AWS-LC. The CI checks that mlkem-native successfully integrates into AWS-LC by building and running basic tests of AWS-LC in FIPS and non-FIPS mode. We test both against a fixed commit and main. Testing against a fixed known-good commit in AWS-LC means we note if we break the integration. Testing against main means we note if a change in AWS-LC breaks the integration. The latter is out of our control, and we may need to temporarily ignore failures, but we should be aware. Signed-off-by: Hanno Becker <[email protected]>
The script importing mlkem-native into AWS-LC does not work as expected on MacOS. While this is the case, patch it up. This commit will be removed once the importer is fixed in AWS-LC. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
aws_lc_integration
branch
2 times, most recently
from
153259e to
8213bee
Compare
mkannwischer
approved these changes
Apr 9, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Awesome! Thanks @hanno-becker for all the work onn the AWS-LC integration!!
This PR adding the integration tests looks good. It may be a bit excessive, but we can trim it down later in case CI is running too slowly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the CI with an integration test for AWS-LC.
The CI checks that mlkem-native successfully integrates into
AWS-LC by building and running basic tests of AWS-LC in FIPS
and non-FIPS mode.
We test both against a fixed commit and main. Testing against a
fixed known-good commit in AWS-LC means we note if we break the
integration. Testing against main means we note if a change in
AWS-LC breaks the integration. The latter is out of our control,
and we may need to temporarily ignore failures, but we should
be aware.