Remove SUPERCOP API from kem.[ch] #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
force-pushed
the
kem_no_supercop
branch
4 times, most recently
from
98c04d0 to
4d3a3ae
Compare
hanno-becker
force-pushed
the
kem_no_supercop
branch
2 times, most recently
from
89c54a1 to
872413c
Compare
mkannwischer
requested changes
Jan 11, 2026
The SUPERCOP API is present both in kem.[ch] and in the public header mlkem_native.h. However, the macro definitions clash due to different namespace wrappers. The SUPERCOP API is merely a convenience for users and not needed in the implementation. This commit removes it from kem.[ch], thereby removing the preprocessor clash with mlkem_native.h. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
kem_no_supercop
branch
from
872413c to
4ef1855
Compare
mkannwischer
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SUPERCOP API is present both in kem.[ch] and in the public header mlkem_native.h. However, the macro definitions clash due to different namespace wrappers.
The SUPERCOP API is merely a convenience for users and not needed in the implementation. This commit removes it from kem.[ch], thereby removing the preprocessor clash with mlkem_native.h.