unit-test: add consistency test for mlk_poly_rej_uniform_x4/x1 - #1431
Merged
Merged
Conversation
willieyz
force-pushed
the
unit-test-x1x4
branch
from
December 24, 2025 08:42
91f57a0 to
fa2cd19
Compare
willieyz
marked this pull request as ready for review
December 24, 2025 11:08
willieyz
marked this pull request as draft
December 24, 2025 11:47
willieyz
force-pushed
the
unit-test-x1x4
branch
3 times, most recently
from
December 28, 2025 12:16
7a98284 to
3faf90a
Compare
willieyz
marked this pull request as ready for review
December 30, 2025 03:29
willieyz
force-pushed
the
unit-test-x1x4
branch
from
December 31, 2025 09:38
3faf90a to
b9d1b24
Compare
willieyz
changed the title
mkannwischer
requested changes
Jan 2, 2026
mkannwischer
left a comment
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
Thanks @willieyz. 3 minor comments.
willieyz
force-pushed
the
unit-test-x1x4
branch
2 times, most recently
from
January 2, 2026 10:06
a2f669a to
b303744
Compare
mkannwischer
requested changes
Jan 4, 2026
mkannwischer
requested changes
Jan 4, 2026
mkannwischer
left a comment
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
Please correct the grammar in the commit message.
willieyz
force-pushed
the
unit-test-x1x4
branch
from
January 5, 2026 03:02
b303744 to
af39520
Compare
mkannwischer
requested changes
Jan 6, 2026
mkannwischer
left a comment
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
Please limit your commit subject to at most 72 characters.
Add unit tests that verify mlk_poly_rej_uniform_x4 processing four different seeds produces the same results as four separate calls to mlk_poly_rej_uniform with those same individual seeds. Introduce NUM_RANDOM_TESTS_REJ_UNIFORM constant to prevent test timeouts on embedded platforms. The poly_rej_uniform operations are computationally intensive and require reduced iteration counts to stay within execution limits on resource-constrained targets like AVR ATmega128RFR2. Signed-off-by: willieyz <willie.zhao@chelpis.com>
willieyz
force-pushed
the
unit-test-x1x4
branch
from
January 6, 2026 06:23
af39520 to
db2c8a9
Compare
mkannwischer
approved these changes
Jan 6, 2026
mkannwischer
left a comment
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
Thanks @willieyz! LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poly_rej_uniform#1293