linting: add shellcheck for shell script lint #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-series
force-pushed
the
shellcheck
branch
2 times, most recently
from
3b2e198 to
ad1f9e0
Compare
hanno-becker
reviewed
Dec 1, 2025
L-series
force-pushed
the
shellcheck
branch
2 times, most recently
from
e61a5c5 to
8635352
Compare
hanno-becker
reviewed
Dec 1, 2025
hanno-becker
requested changes
Dec 1, 2025
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
Thank you @L-series, in general I think linting the shell scripts is a great idea -- esp. seeing that at least I'm not a shell expert.
However, it looks like some of the quoting has broken scripts/lint, at least the Lint Shell command. Can you have a look, both at the issue itself and why the CI did not catch it?
Contributor
Author
|
@hanno-becker Hello, please see my comment above regarding what the issue was with the I'm adding a variable which tracks the shells scripts which exist across the project and I pass that to both |
L-series
force-pushed
the
shellcheck
branch
3 times, most recently
from
054002b to
67a36aa
Compare
hanno-becker
reviewed
Dec 2, 2025
hanno-becker
reviewed
Dec 2, 2025
mkannwischer
changed the title
L-series
force-pushed
the
shellcheck
branch
5 times, most recently
from
c2209ca to
7482a42
Compare
L-series
force-pushed
the
shellcheck
branch
4 times, most recently
from
f2f74f3 to
9dd0fa7
Compare
L-series
force-pushed
the
shellcheck
branch
3 times, most recently
from
8c1b11e to
f17ce9f
Compare
hanno-becker
reviewed
Jan 4, 2026
L-series
force-pushed
the
shellcheck
branch
2 times, most recently
from
9430670 to
397da23
Compare
Add linting for shell scripts in the scipts directory as well as any *.sh file accross the project using shellcheck. Signed-off-by: Andreas Hatziiliou <[email protected]>
Fix errors brought up by the linter. Signed-off-by: Andreas Hatziiliou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add linting for shell scripts in the scipts directory as well as any
*.sh file accross the project using shellcheck.