[TEST] Reduce crypto_sign_verify_internal stack usage
#751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
verify-internal-ram
branch
2 times, most recently
from
e5c0a95 to
a136a71
Compare
Contributor
|
This comment was marked as outdated.
This comment was marked as outdated.
- Add mld_polymat_get_row() to retrieve matrix row pointer - Update mld_polyvec_matrix_pointwise_montgomery() to use helper Addresses #738 (steps 2-3 of #736) Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
crypto_sign_verify_internal stack: before: 26928/37232/49776 after: 22784/31040/41536 Signed-off-by: Matthias J. Kannwischer <[email protected]>
crypto_sign_verify_internal stack: 21743/30016/40515 Signed-off-by: Matthias J. Kannwischer <[email protected]>
crypto_sign_verify_internal stack: 17664/24864/33312 Signed-off-by: Matthias J. Kannwischer <[email protected]>
crypto_sign_verify_internal stack: 14592/19744/26144 Signed-off-by: Matthias J. Kannwischer <[email protected]>
crypto_sign_verify_internal stack: 13568/18720/25120 Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
force-pushed
the
verify-internal-ram
branch
from
a136a71 to
90a2202
Compare
mkannwischer
added a commit
that referenced
this pull request
Jan 9, 2026
This commit is the first of a series of commits reducing the stack usage of verification. It is hoisted out from #751 This commit places the t1 and w1 buffers into a union saving K KiB of memory. As CBMC struggles with unions (issue 8813), we use the same workaround present in signing: Use a struct by default, and a union when MLD_CONFIG_REDUCE_RAM is set. Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
added a commit
that referenced
this pull request
Jan 9, 2026
This commit is the first of a series of commits reducing the stack usage of verification. It is hoisted out from #751 This commit places the t1 and w1 buffers into a union saving K KiB of memory. Operations using it are slightly reordered such that their lifetime does not overlap. As CBMC struggles with unions (issue 8813), we use the same workaround present in signing: Use a struct by default, and a union when MLD_CONFIG_REDUCE_RAM is set. Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
added a commit
that referenced
this pull request
Jan 9, 2026
This commit is the first of a series of commits reducing the stack usage of verification. It is hoisted out from #751 This commit places the t1 and w1 buffers into a union saving K KiB of memory. Operations using it are slightly reordered such that their lifetime does not overlap. As CBMC struggles with unions (issue 8813), we use the same workaround present in signing: Use a struct by default, and a union when MLD_CONFIG_REDUCE_RAM is set. Signed-off-by: Matthias J. Kannwischer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the stack usage of
crypto_sign_verify_internalbased on top of #743 using simple restructuring and sharing buffers.CBMC proofs are not yet adjusted.