Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement visual component for displaying submission progress #31803

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Feb 5, 2025

2025-02-05.13-54-47.mp4

Will be used to show progress of submission stages as they happen. Split out due to size.

@peppy
Copy link
Member

peppy commented Feb 6, 2025

Hmm, does the fact StageDescription can't be mutated imply that the progress bar will reset for each "stage"? I'd prooobably hope that we have a single progress bar that shows the overall progress, but I can live with this approach if it looks good. Is there somewhere I can see this in action with multiple "stages"?

@peppy
Copy link
Member

peppy commented Feb 6, 2025

Never mind, I found the example I was looking for in #31805 😄 .

Let's go with this for now, it looks good enough (with some minor transform changes at the end of the sequence of PRs, possibly).

@peppy peppy merged commit 4fda4d6 into ppy:master Feb 6, 2025
10 checks passed
@bdach bdach deleted the bss/submission-progress-display branch February 6, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants