Display up-to-date online status in user panels #31524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As for the tests, I'm (ab)using the `IsOnline` state for the time being to restore functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13604
Prereqs:
StatusandActivitybindables fromAPIUser#31513I've chosen to ignore
APIUser.IsOnlinebecause it's potentially going to be out-of-date with the model cached inUserLookupCache. We're eventually going to have aMetadataClient.RequestPresenceUpdate(user)to keep it up-to-date, but this is fine for now because I can't find these panels actually displayed anywhere else.Preview (ignore error at the end -- nondescript segfault on random thread...):
2025-01-15.16-49-35.mp4