Bump beatmap set last update date even if the contents didn't change #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matters in one specific case - if the no-op update also happened to ungraveyard the set in question, not bumping the last update date will cause the set to re-enter the graveyard the very next day due to web-10 logic being based around last update date: https://github.com/peppy/osu-web-10/blob/2723bd9f63e243c506336494509d1b72fb92872d/www/web/update_forums.php#L31 which does not seem to match the intention of the user when updating a graveyarded beatmap like that.
peppy
approved these changes
Oct 6, 2025
github-project-automation
bot
moved this from Pending Review
to Done
in @peppy's untitled project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matters in one specific case - if the no-op update also happened to ungraveyard the set in question, not bumping the last update date will cause the set to re-enter the graveyard the very next day due to web-10 logic being based around last update date, which does not seem to match the intention of the user when updating a graveyarded beatmap like that.