Show better error message on exceeding absolute request body cap #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got dinged a few times yesterday on sentry (https://sentry.ppy.sh/organizations/ppy/issues/73418/?project=12) because somebody hit the absolute 200MB cap a few times. This change is designed to (a) stop that from dinging on sentry because there's really no reason to log it as error, and (b) give the user a better error message to work with because the current one was kinda opaque (would just show "BadRequest" or similar).
bdach
changed the title
peppy
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got dinged a few times yesterday on sentry (https://sentry.ppy.sh/organizations/ppy/issues/73418/?project=12) because somebody hit the absolute 200MB cap a few times.
This change is designed to (a) stop that from dinging on sentry because there's really no reason to log it as error, and (b) give the user a better error message to work with because the current one was kinda opaque (would just show "BadRequest" or similar).