Ensure a build suffix is added to incoming version

[peppy]

This is just a sanity thing to match expectations of the client.

[smoogipoo]

I'm not sure the Android builder is going to like this:

osu-deploy/Builders/AndroidBuilder.cs

Lines 39 to 42 in 8ab7946

	string[] versionParts = Version.Split('.');
	string versionCode = versionParts[0].PadLeft(4, '0') + versionParts[1].PadLeft(4, '0') + versionParts[2].PadLeft(1, '0');
	RunDotnetPublish($"-p:ApplicationVersion={versionCode} {codeSigningArguments}");

Also note that both the Velopack and GH uploaders match the release by tag with this name:

osu-deploy/Uploaders/VelopackUploader.cs

Lines 70 to 71 in 8ab7946

	+ $" --tag=\"{version}\""
	+ $" --releaseName=\"{version}\""

osu-deploy/Uploaders/GitHubUploader.cs

Line 32 in 8ab7946

if (targetRelease == null || targetRelease.TagName != version)

I don't know how this behaves exactly so have you tested this? Android/iOS is a much of a muchness but at least in-so-far as you've tested you can actually upload vpk releases to GH with your intended tagging workflow.

Because, it does mean that the if condition doesn't actually make much sense here - if version is arriving without a suffix then releases aren't going to get matched.

[peppy]

I'm not sure the Android builder is going to like this:

may need custom handling, didn't notice this.

Also note that both the Velopack and GH uploaders match the release by tag with this name:

Tag is probably what we want, but maybe not release name, I'l check on this.

[peppy]

I've fixed the android builder issue. The other issue you bring up doesn't seem like it needs any changes, but I haven't done a test of this yet.

One thing I'd want to confirm is that it is okay to have the suffix in the release asset filenames?

ie does velopack manage things based on PackageId and this is a non-issue as a result?

[smoogipoo]

Yes it's fine. The asset filenames don't matter as long as it's velopack that's generating them.

[peppy]

In that case I think we could get this in and do a test run (then pull the build quickly if there's any issues).

[smoogipoo]

Haven't tested so this is just a blanket approval.