Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch snapshot ci to new app and rework notification design #938

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Jan 29, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
CI uses some action to format slack notification
image

What is the new behavior (if this is a feature change)?
Better format
image

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Existing integration branches for the current snapshot version of powsybl-core should be renamed by adding the prefix integration/powsybl-core-. (For instance, 6.7.0-SNAPSHOT => integration/powsybl-core-6.7.0-SNAPSHOT).

Other information:

⚠️ Important note: Before this PR, the integration branches used for each repo were called with the snapshot version of powsybl-core (for instance 6.6.0-SNAPSHOT). Now their name should be prefixed with integration/powsyblcore-. In our previous example, the branches must be called integration/powsyblcore-6.6.0-SNAPSHOT.
As a consequence, only maintainers can create these branches or force-push into them (see the branching strategy documentation).

Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico changed the title Nro/switch snapshot ci to new app Switch snapshot ci to new app and rework notification design Jan 29, 2025
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico marked this pull request as ready for review January 31, 2025 16:12
@olperr1
Copy link
Member

olperr1 commented Feb 5, 2025

Once merged, powsybl/powsybl-dev-tools#120 should be adapted to reflect the integration branch naming pattern change.

.github/workflows/snapshot-ci.yml Outdated Show resolved Hide resolved
- name: Checkout core sources
uses: actions/checkout@v4
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow previously worked with the default v4 version (so v4.2.2).
Did something prevents to use this version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I just put the same version we use on some other repos but we surely can update it

- name: Upload wheel
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # 4.3.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this action:
The workflow previously worked with the default v4 version (so v4.6.0).
Did something prevents to use this version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same answer

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants