-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch snapshot ci to new app and rework notification design #938
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Once merged, powsybl/powsybl-dev-tools#120 should be adapted to reflect the integration branch naming pattern change. |
.github/workflows/snapshot-ci.yml
Outdated
- name: Checkout core sources | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow previously worked with the default v4 version (so v4.2.2).
Did something prevents to use this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I just put the same version we use on some other repos but we surely can update it
.github/workflows/snapshot-ci.yml
Outdated
- name: Upload wheel | ||
uses: actions/upload-artifact@v4 | ||
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # 4.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this action:
The workflow previously worked with the default v4 version (so v4.6.0).
Did something prevents to use this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same answer
Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
|
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
![image](https://private-user-images.githubusercontent.com/135979730/409003917-5ffdd958-bb4e-411f-84a5-8bdfdd452542.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjczMDksIm5iZiI6MTczOTI2NzAwOSwicGF0aCI6Ii8xMzU5Nzk3MzAvNDA5MDAzOTE3LTVmZmRkOTU4LWJiNGUtNDExZi04NGE1LThiZGZkZDQ1MjU0Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQwOTQzMjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMGZiOWNlMWUwMDBlZjEwYTUyYzc4OWY0M2RhMDBhNDEyOWUwZjM2MDFhZjFmYTJmZjk0ZGZlN2U5NTlmNDU5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.VvVqff03rIALmUMfcY9mLjUd0V8FHYTLF77P3jrPp7o)
CI uses some action to format slack notification
What is the new behavior (if this is a feature change)?
![image](https://private-user-images.githubusercontent.com/135979730/409003989-f8059e17-43b8-46a0-97c0-e8f041313563.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjczMDksIm5iZiI6MTczOTI2NzAwOSwicGF0aCI6Ii8xMzU5Nzk3MzAvNDA5MDAzOTg5LWY4MDU5ZTE3LTQzYjgtNDZhMC05N2MwLWU4ZjA0MTMxMzU2My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQwOTQzMjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZTIzZGQ3NTgzMmY4ODYxYTYxYmMxNTBjYjBiMTg5NmU0NTVjOThjYjk1YTI5Y2QyZDVhODMwMDczZDA2ZDhlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.uYyGShQm3FhGWct_d9aS4B5-4Y4yBpdN6KFbNQXJpsM)
Better format
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Existing integration branches for the current snapshot version of powsybl-core should be renamed by adding the prefix
integration/powsybl-core-
. (For instance,6.7.0-SNAPSHOT
=>integration/powsybl-core-6.7.0-SNAPSHOT
).Other information:
6.6.0-SNAPSHOT
). Now their name should be prefixed withintegration/powsyblcore-
. In our previous example, the branches must be calledintegration/powsyblcore-6.6.0-SNAPSHOT
.As a consequence, only maintainers can create these branches or force-push into them (see the branching strategy documentation).