Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 windings transformers ratio and phase tap changers #937

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Jan 28, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

We cannot see ratio and phase tap changers and tap changers steps for 3 windings transformers.

What is the new behavior (if this is a feature change)?
Ratio and phase tap changers and tap changers steps for 3 windings transformers have been added to existing table along with 2 windings transformers. A side column has been added because a 3 windings transformer can have multiple ratio and phase tap changers on different legs. For backward compatibility reason, side has not been added to the index.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

  • fictitious attribute has been removed from ratio and phase tap changer dataframe because in IIDM, fictitious is at identifable level (so transformer).
  • rho attribute of ratio tap changer has been moved to 2 windings transformer ans 3 windings transformer (rho1, rho2 and rho3) because it is using data of transformer + ratio tap changer steps + phase tap changer steps so a calculated attribute of the transformer itself.

Other information:

Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg geofjamg changed the title [WIP] Add 3 windings transformers ratio and phase tap changers Add 3 windings transformers ratio and phase tap changers Jan 28, 2025
@geofjamg geofjamg requested a review from HugoKulesza January 28, 2025 12:25
Copy link
Collaborator

@HugoKulesza HugoKulesza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are just the docstrings of getter methods for rtc/ptc and steps in python to change accordingly but otherwise all is good

Copy link

Copy link

@geofjamg geofjamg requested a review from HugoKulesza January 30, 2025 14:02
@HugoKulesza HugoKulesza merged commit b713a69 into main Jan 31, 2025
10 checks passed
@HugoKulesza HugoKulesza deleted the tap_changer_3_windings branch January 31, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants